Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary parameter from NewHTTPServer #2538

Merged
merged 1 commit into from
Apr 10, 2017
Merged

Remove unnecessary parameter from NewHTTPServer #2538

merged 1 commit into from
Apr 10, 2017

Conversation

sheerun
Copy link
Contributor

@sheerun sheerun commented Apr 10, 2017

Just a cleanup

@dadgar
Copy link
Contributor

dadgar commented Apr 10, 2017

Thanks @sheerun

@dadgar dadgar merged commit 83be4ad into hashicorp:master Apr 10, 2017
@sheerun
Copy link
Contributor Author

sheerun commented Apr 10, 2017

I think I broke the tests though ;(

@dadgar
Copy link
Contributor

dadgar commented Apr 10, 2017

Those tests are flakey. I don't think your commit had any affect on them 👍

@github-actions
Copy link

github-actions bot commented Apr 2, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheerun @dadgar