Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Volumes and plugins navigation fixes, generally #24542

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

philrenaud
Copy link
Contributor

Description

Mainly, this fixes a bug where navigating to a volume from the Storage page would error. This was happening because it was escaping the / after the csi/ prefix that Ember Data uses to route things. I made a similar bugfix a few months ago for plugins, but didn't think to check volumes as well

Additionally, found a few more quality-of-life around navigation within storage:

  • There was no keyboard nav for the plugins index table
  • the u keyboard shortcut would pass more info than needed to get from /volumes/:id back to /volumes (this is because it's one level more nested than most breadcrumb up-a-level nav; /storage/plugins and /storage are the same page, as far as breadcrumbs are concerned)
  • Enumerated keyboard nav to load a volume from the index page was not working, even after the above csi/ slash escaping bug was fixed; this was because the DOM event being passed to our lazyClick method (to simulate clicking on a row when you type in a keynav combo, in this case) was coming back null. There's now a defensive Elvis (?.) to return a falsy value in lazyClick.

Testing & Reproduction steps

Make some volumes/plugins and navigate around to your heart's content

Resolves #23831

@philrenaud philrenaud added the backport/1.9.x backport to 1.9.x release line label Nov 22, 2024
@philrenaud philrenaud self-assigned this Nov 22, 2024
@philrenaud philrenaud requested review from a team as code owners November 22, 2024 17:31
@philrenaud philrenaud linked an issue Nov 22, 2024 that may be closed by this pull request
@philrenaud philrenaud force-pushed the 23831-csi-volumes-cannot-be-displayed-in-nomad-18-gui branch from 7f25b60 to 8d28d62 Compare November 22, 2024 17:32
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this down locally to try it out and LGTM in terms of functionality.

It looks like we broke some of the unit tests for volumes in the process though, and I think the Mirage fixtures need to be updated because the preview on Vercel won't let you click through to the individual volume pages.

Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT in terms of functionality, and from what I can tell JS looks good, but my confidence in that area is low.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.9.x backport to 1.9.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSI volumes cannot be displayed in Nomad 1.8 GUI
3 participants