Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: documentation of idempotency_token in API #24317

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

EtienneBruines
Copy link
Contributor

The parsing of the idempotency_token requires snake case, as it is a URL query parameter and not part of the JSON request body.

See also:

// parseIdempotencyToken is used to parse the ?idempotency_token parameter

The parsing of the idempotency_token requires snake case, as it is a URL query parameter and not part of the JSON request body. 

See also: https://github.com/hashicorp/nomad/blob/2df473c5612cd46000bad755221de49e994256ba/command/agent/http.go#L951
Copy link
Contributor

@aimeeu aimeeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@aimeeu aimeeu added theme/docs Documentation issues and enhancements backport/website This will backport PR changes to `stable-website` && the latest release-branch backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent backport/1.9.x backport to 1.9.x release line backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.8.x backport to 1.8.x release line labels Oct 29, 2024
@aimeeu aimeeu merged commit 09703b2 into hashicorp:main Oct 29, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent backport/website This will backport PR changes to `stable-website` && the latest release-branch backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line backport/1.8.x backport to 1.8.x release line backport/1.9.x backport to 1.9.x release line theme/docs Documentation issues and enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants