Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified package documentation for executor #233

Merged
merged 4 commits into from
Oct 8, 2015
Merged

Conversation

cbednarski
Copy link
Contributor

There was some confusion as to the purpose of executors in #232. I clarified the executor package documentation so the design is hopefully a bit more clear, including some examples.

// available capabilities of each platform to provide resource constraints,
// process isolation, and security features, or otherwise take advantage of
// features that are unique to that platform.
// A "platform" may something like "windows" or "linux with systemd". Executors

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/may/may be/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@catsby
Copy link
Contributor

catsby commented Oct 8, 2015

👍 more clear now

@dadgar
Copy link
Contributor

dadgar commented Oct 8, 2015

Looks good to me

cbednarski added a commit that referenced this pull request Oct 8, 2015
Clarified package documentation for executor
@cbednarski cbednarski merged commit ae87aaf into master Oct 8, 2015
@cbednarski cbednarski deleted the docs-executor branch October 8, 2015 18:36
benbuzbee pushed a commit to benbuzbee/nomad that referenced this pull request Jul 21, 2022
@github-actions
Copy link

github-actions bot commented May 8, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants