Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI: allow plugin GC to detect jobs with updated plugin IDs #20555

Merged
merged 1 commit into from
May 16, 2024

Commits on May 10, 2024

  1. CSI: allow plugin GC to detect jobs with updated plugin IDs

    When a job that implements a plugin is updated to have a new plugin ID, the old
    version of the plugin is never deleted. We want to delay deleting plugins until
    garbage collection to avoid race conditions between a plugin being registered
    and its allocations being marked healthy.
    
    Add logic to the state store's `DeleteCSIPlugin` method (used only by GC) to
    check whether any of the jobs associated with the plugin have no allocations and
    either have been purged or have been updated to no longer implement that plugin
    ID.
    
    This changeset also updates the CSI plugin lifecycle tests in the state store to
    use `shoenig/test` over `testify`, and removes a spurious error log that was
    happening on every periodic plugin GC attempt.
    
    Fixes: #20225
    tgross committed May 10, 2024
    Configuration menu
    Copy the full SHA
    6568fc8 View commit details
    Browse the repository at this point in the history