Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tproxy: job submission hooks #20244

Merged
merged 2 commits into from
Apr 4, 2024
Merged

tproxy: job submission hooks #20244

merged 2 commits into from
Apr 4, 2024

Conversation

tgross
Copy link
Member

@tgross tgross commented Mar 27, 2024

Add a constraint on job submission that requires the consul-cni plugin fingerprint whenever transparent proxy is used. Add a validation that the network.dns cannot be set when transparent proxy is used, unless the no_dns flag is set.

This PR targets the feature branch.
Ref: #20175

Add a constraint on job submission that requires the `consul-cni` plugin
fingerprint whenever transparent proxy is used.

Add a validation that the `network.dns` cannot be set when transparent proxy is
used, unless the `no_dns` flag is set.
Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple tidbits for ya, lgtm!

nomad/job_endpoint_hooks.go Outdated Show resolved Hide resolved
nomad/structs/job.go Outdated Show resolved Hide resolved
@tgross tgross merged commit 0741d00 into f-tproxy Apr 4, 2024
17 of 18 checks passed
@tgross tgross deleted the f-tproxy-submit-hooks branch April 4, 2024 15:02
tgross added a commit that referenced this pull request Apr 4, 2024
Add a constraint on job submission that requires the `consul-cni` plugin
fingerprint whenever transparent proxy is used.

Add a validation that the `network.dns` cannot be set when transparent proxy is
used, unless the `no_dns` flag is set.
tgross added a commit that referenced this pull request Apr 4, 2024
Add a constraint on job submission that requires the `consul-cni` plugin
fingerprint whenever transparent proxy is used.

Add a validation that the `network.dns` cannot be set when transparent proxy is
used, unless the `no_dns` flag is set.
tgross added a commit that referenced this pull request Apr 5, 2024
Add a constraint on job submission that requires the `consul-cni` plugin
fingerprint whenever transparent proxy is used.

Add a validation that the `network.dns` cannot be set when transparent proxy is
used, unless the `no_dns` flag is set.
tgross added a commit that referenced this pull request Apr 5, 2024
Add a constraint on job submission that requires the `consul-cni` plugin
fingerprint whenever transparent proxy is used.

Add a validation that the `network.dns` cannot be set when transparent proxy is
used, unless the `no_dns` flag is set.
philrenaud pushed a commit that referenced this pull request Apr 18, 2024
Add a constraint on job submission that requires the `consul-cni` plugin
fingerprint whenever transparent proxy is used.

Add a validation that the `network.dns` cannot be set when transparent proxy is
used, unless the `no_dns` flag is set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants