Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect: rewrite envoy bootstrap on every restart #19787

Merged
merged 8 commits into from
Jan 24, 2024
Merged

connect: rewrite envoy bootstrap on every restart #19787

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7a0c8f0
connect: rewrite envoy bootstrap on every restart
schmichael Jan 20, 2024
714c3a2
changelog
schmichael Jan 20, 2024
b29e6db
remove done assertion
schmichael Jan 22, 2024
ae8b89f
add scary warning to Done flag
schmichael Jan 22, 2024
78e726e
rerun connect native hook
schmichael Jan 22, 2024
f70e385
remove Done from envoy bootstrap entirely
schmichael Jan 22, 2024
3420557
never done
schmichael Jan 24, 2024
8778f78
never ever done
schmichael Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/19787.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
connect: Fixed envoy sidecars being unable to restart after node reboots
```
4 changes: 2 additions & 2 deletions client/allocrunner/taskrunner/envoy_bootstrap_hook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@ func (h *envoyBootstrapHook) Prestart(ctx context.Context, req *ifs.TaskPrestart

// Command succeeded, exit.
if cmdErr == nil {
// Bootstrap written. Mark as done and move on.
resp.Done = true
// Bootstrap written. Move on without marking as Done as Prestart needs
// to rerun after node reboots.
return false, nil
}

Expand Down
Loading