Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of cli: non-service jobs on job restart -reschedule into release/1.6.x #19223

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #19147 to be assessed for backporting due to the inclusion of the label backport/1.6.x.

The below text is copied from the body of the original PR.


The -reschedule flag stops allocations and assumes the Nomad scheduler will create new allocations to replace them. But this is only true for service jobs.

Restarting non-service jobs with the -reschedule flag causes the command to loop forever waiting for the allocations to be replaced, which never happens.

Allocations for system jobs may be replaced by triggering an evaluation after each stop to cause the reconciler to run again.

Batch and sysbatch jobs should not be allowed to be rescheduled as they are expected to run to completion unless stopped.

Closes #19043


Overview of commits

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-cli-handle-job-restart-types/heavily-frank-stingray branch from 2fb7712 to 37f23c3 Compare November 29, 2023 18:01
@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-cli-handle-job-restart-types/heavily-frank-stingray branch from a36557c to 5fe319a Compare November 29, 2023 18:01
@vercel vercel bot temporarily deployed to Preview – nomad November 29, 2023 18:10 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad-storybook-and-ui November 29, 2023 18:12 Inactive
@lgfa29 lgfa29 merged commit 1fa0b4f into release/1.6.x Nov 29, 2023
24 of 26 checks passed
@lgfa29 lgfa29 deleted the backport/b-cli-handle-job-restart-types/heavily-frank-stingray branch November 29, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants