Action CLI command #18778
Merged
Action CLI command #18778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
force-pushed
the
18735-socket-endpoint
branch
from
a3621e2
to
fb1f31a
Compare
tgross
reviewed
Oct 17, 2023
philrenaud
force-pushed
the
18771-nomad-actions-cli-command
branch
from
7495618
to
165b391
Compare
tgross
reviewed
Oct 17, 2023
tgross
reviewed
Oct 17, 2023
philrenaud
force-pushed
the
18735-socket-endpoint
branch
from
fb1f31a
to
0a308a1
Compare
philrenaud
force-pushed
the
18771-nomad-actions-cli-command
branch
from
3fc1957
to
56570a4
Compare
philrenaud
force-pushed
the
18771-nomad-actions-cli-command
branch
from
56570a4
to
6a159de
Compare
philrenaud
force-pushed
the
18771-nomad-actions-cli-command
branch
from
714d14d
to
92a1828
Compare
philrenaud
force-pushed
the
18771-nomad-actions-cli-command
branch
from
92a1828
to
8c077f1
Compare
philrenaud
changed the title
tgross
reviewed
Oct 19, 2023
tgross
reviewed
Oct 19, 2023
tgross
approved these changes
Oct 19, 2023
philrenaud
force-pushed
the
18771-nomad-actions-cli-command
branch
from
8962e8f
to
753b2d7
Compare
…, get random alloc w group adherence
philrenaud
force-pushed
the
18771-nomad-actions-cli-command
branch
from
1a4101c
to
d2db7c2
Compare
philrenaud
added a commit
that referenced
this pull request
Oct 20, 2023
* Scaffolding actions (#18639) * Task-level actions for job submissions and retrieval * FIXME: Temporary workaround to get ember dev server to pass exec through to 4646 * Update api/tasks.go Co-authored-by: Tim Gross <[email protected]> * Update command/agent/job_endpoint.go Co-authored-by: Tim Gross <[email protected]> * Diff and copy implementations * Action structs get their own file, diff updates to behave like our other diffs * Test to observe actions changes in a version update * Tests migrated into structs/diff_test and modified with PR comments in mind * APIActionToSTructsAction now returns a new value * de-comment some plain parts, remove unused action lookup * unused param in action converter --------- Co-authored-by: Tim Gross <[email protected]> * New endpoint: job/:id/actions (#18690) * unused param in action converter * backing out of parse_job level and moved toward new endpoint level * Adds taskName and taskGroupName to actions at job level * Unmodified job mock actions tests * actionless job test * actionless job test * Multi group multi task actions test * HTTP method check for GET, cleaner errors in job_endpoint_test * decomment * Actions aggregated at job model level (#18733) * Removal of temporary fix to proxy to 4646 * Run Action websocket endpoint (#18760) * Working demo for review purposes * removal of cors passthru for websockets * Remove job_endpoint-specific ws handlers and aimed at existing alloc exec handlers instead * PR comments adressed, no need for taskGroup pass, better group and task lookups from alloc * early return in action validate and removed jobid from req args per PR comments * todo removal, we're checking later in the rpc * boolean style change on tty * Action CLI command (#18778) * Action command init and stuck-notes * Conditional reqpath to aim at Job action endpoint * De-logged * General CLI command cleanup, observe namespace, pass action as string, get random alloc w group adherence * tab and varname cleanup * Remove action param from Allocations().Exec calls * changelog * dont nil-check acl --------- Co-authored-by: Tim Gross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
nomad actionCLI command. Can be used to run a task action either by passing an allocation ID + job, or job + group + task:As a side-effect, also adds an optional
tasakGroupNameparam togetRandomJobAlloc, in order to only select allocations that have the specified action name.