Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: Rename functions and use iterator function for clarity #18716

Merged
merged 2 commits into from
Oct 11, 2023
Merged

server: Rename functions and use iterator function for clarity #18716

merged 2 commits into from
Oct 11, 2023

Conversation

Juanadelacuesta
Copy link
Member

This PR backports some changes from the ent repo for consistency.

@Juanadelacuesta Juanadelacuesta marked this pull request as ready for review October 10, 2023 18:24
@Juanadelacuesta Juanadelacuesta changed the title server: Rename functions and user iterator function for clarity server: Rename functions and use iterator function for clarity Oct 10, 2023
lgfa29
lgfa29 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit with some changes missing that the automated git apply found.

@Juanadelacuesta Juanadelacuesta merged commit 70b020e into main Oct 11, 2023
21 checks passed
@Juanadelacuesta Juanadelacuesta deleted the f-gh-1106-style branch October 11, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgfa29 lgfa29 lgfa29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Juanadelacuesta @lgfa29