backport test: Refactor mock CSI manager into release/1.5.x #18561
Conversation
and MockCSIManager to support the call counting that csi_hook_test expects instead of implementing csimanager interfaces in two separate places: * client/allocrunner/csi_hook_test * client/csi_endpoint_test they can both use the same mocks defined in client/pluginmanager/csimanager/ alongside the actual implementations of them. also refactor TestCSINode_DetachVolume to use use it like Node_ExpandVolume so we can also test the happy path there
gulducat
changed the title
There was a problem hiding this comment.
I give a conditional LGTM as long as we all agree we're backporting changes like this. My understanding was that up until now these sort of changes weren't backported, but I guess having them in previous releases makes other backports less prone to conflicts?
There was a problem hiding this comment.
LGTM!
I give a conditional LGTM as long as we all agree we're backporting changes like this. My understanding was that up until now these sort of changes weren't backported, but I guess having them in previous releases makes other backports less prone to conflicts?
You're totally right @pkazmierczak that we generally only backport bug fixes. But yeah, having test code like this makes our future backports less painful, without breaking the promises we make to users (that you typically only get new features in the new versions).
manual backport of #18554 - 7bd5c6e to 1.5.x
auto backport should work for 1.4.x from here.