ci: clean GOCACHE before build #17808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is basically to avoid Fear/Uncertainty/Doubt the github action actions/setup-go (and, with a different chache key, hashicorp/setup-golang) caches both GOMODCACHE (go source files), which is good, and GOCACHE (build outputs), which *might* be bad, if the cache was built on an OS with an older glibc than we want to support. from `go help cache`: > [...] the build cache does not detect changes to > C libraries imported with cgo.
gulducat
added
backport/1.3.x
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically to avoid Fear/Uncertainty/Doubt.
The github action actions/setup-go (and, with a different chache key, hashicorp/setup-golang) caches both GOMODCACHE (go source files), which is good, and GOCACHE (build outputs), which might be bad, if the cache was built on an OS with an older glibc than we want to support. from
go help cache:I think we've been okay so far, because the cache has always(~?) been built on 20.04 machines, but to be safe, this wipes the build cache (leaving the mod cache alone) before building.
related PR that checks the build after the fact: #17706