Backport of deps: update go-metrics to prevent panic into release/1.4.x #17152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nomad#15861 describes intermitent panics caused by go-metrics Prometheus client. We have not been able to further debug this problem due to the lack of information when the panic happens. go-metrics#146 prevents the panic from happening and also logs additional information that can help us understand the root cause of the problem. This commits pins the go-metric dependency to this branch until we can better debug the issue.
lgfa29
force-pushed
the
backport/deps-update-go-metrics/thankfully-renewing-beetle
branch
from
b4334ea
to
1108b32
Compare
lgfa29
deleted the
backport/deps-update-go-metrics/thankfully-renewing-beetle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17133 to be assessed for backporting due to the inclusion of the label backport/1.4.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
#15861 describes intermittent panics caused by go-metrics Prometheus client. We have not been able to further debug this problem due to the lack of information when the panic happens.
hashicorp/go-metrics#146 prevents the panic from happening and also logs additional information that can help us understand the root cause of the problem.
This commits pins the go-metric dependency to this branch until we can better debug the issue.