cni: fix plugin fingerprinting versions #16776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
suggested changes
Apr 19, 2023
There was a problem hiding this comment.
Ah thanks for letting us know @EtienneBruines.
As expected, this change breaks our tests 😅
https://github.com/hashicorp/nomad/actions/runs/4598672300/jobs/8185888257?pr=16776
Do you think you would be able to fix them?
CNI plugins v1.2.0 and above output a second line, containing supported protocol versions.
EtienneBruines
changed the title
lgfa29
added
backport/1.3.x
lgfa29
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Thanks for the updates @EtienneBruines!
I pushed a couple of commits to slightly simplify the token loop logic and to add a changelog entry.
lgfa29
added
backport/1.3.x
lgfa29
pushed a commit
that referenced
this pull request
Apr 21, 2023
CNI plugins v1.2.0 and above output a second line, containing supported protocol versions.
lgfa29
pushed a commit
that referenced
this pull request
Apr 21, 2023
CNI plugins v1.2.0 and above output a second line, containing supported protocol versions.
lgfa29
pushed a commit
that referenced
this pull request
Apr 21, 2023
CNI plugins v1.2.0 and above output a second line, containing supported protocol versions. Co-authored-by: Etienne Bruines <[email protected]>
lgfa29
pushed a commit
that referenced
this pull request
Apr 21, 2023
CNI plugins v1.2.0 and above output a second line, containing supported protocol versions. Co-authored-by: Etienne Bruines <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNI plugins v1.2.0 and above output a second line, containing supported protocol versions. Nomad tests should support this.