Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of drivers/exec: Fix handling of capabilities for unprivileged tasks into release/1.5.x #16697

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #16643 to be assessed for backporting due to the inclusion of the label backport/1.5.x.

The below text is copied from the body of the original PR.


Currently, the exec driver is only setting the Bounding set, which is
not sufficient to actually enable the requisite capabilities for the
task process. In order for the capabilities to survive execve
performed by libcontainer, the Permitted, Inheritable, and Ambient
sets must also be set.

Per CAPABILITIES (7):

Ambient: This is a set of capabilities that are preserved across an
execve(2) of a program that is not privileged. The ambient capability
set obeys the invariant that no capability can ever be ambient if it
is not both permitted and inheritable.

Fixes: #16642

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/fix-exec-caps/definitely-moved-pony branch from 8f9aabf to f2d722f Compare March 28, 2023 16:18
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 4592d96 into release/1.5.x Mar 28, 2023
@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/fix-exec-caps/definitely-moved-pony branch from 0883270 to 94bd7eb Compare March 28, 2023 16:18
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/fix-exec-caps/definitely-moved-pony branch March 28, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants