-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] Deployment History search #16608
Merged
philrenaud
merged 5 commits into
16512-service-job-deployment-panel-history-and-update-params
from
16512-deployment-history-search
Mar 24, 2023
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
efe6f3a
Functioning searchbox
philrenaud eb14519
Some nice animations for history items
philrenaud 8adb9f0
History search test
philrenaud a3a9f70
Fixing up some old mirage conventions
philrenaud ca9e90a
some a11y rule override to account for scss keyframes
philrenaud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -173,15 +173,41 @@ | |
display: grid; | ||
grid-template-columns: 70% auto; | ||
gap: 1rem; | ||
margin-top: 1rem; // TODO: grid-ify the deployment panel generally and just use gap for this | ||
margin-top: 2rem; // TODO: grid-ify the deployment panel generally and just use gap for this | ||
} | ||
|
||
.deployment-history { | ||
& > header { | ||
display: grid; | ||
grid-template-columns: 1fr 2fr; | ||
gap: 1rem; | ||
margin-bottom: 1rem; | ||
align-items: end; | ||
& > .search-box { | ||
max-width: unset; | ||
} | ||
} | ||
& > ol { | ||
max-height: 300px; | ||
overflow-y: auto; | ||
} | ||
& > ol > li { | ||
@for $i from 1 through 50 { | ||
&:nth-child(#{$i}) { | ||
animation-name: historyItemSlide; | ||
animation-duration: 0.2s; | ||
animation-fill-mode: both; | ||
animation-delay: 0.1s + (0.05 * $i); | ||
} | ||
|
||
&:nth-child(#{$i}) > div { | ||
animation-name: historyItemShine; | ||
animation-duration: 1s; | ||
animation-fill-mode: both; | ||
animation-delay: 0.1s + (0.05 * $i); | ||
} | ||
} | ||
Comment on lines
+195
to
+209
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. SCSS iterator format; this lets us do things like animations that look like they roll in one at a time. New to our codebase, but a proven pattern. |
||
|
||
& > div { | ||
gap: 0.5rem; | ||
} | ||
|
@@ -218,3 +244,23 @@ | |
} | ||
} | ||
} | ||
|
||
@keyframes historyItemSlide { | ||
from { | ||
opacity: 0; | ||
top: 40px; | ||
} | ||
to { | ||
opacity: 1; | ||
top: 0px; | ||
} | ||
} | ||
|
||
@keyframes historyItemShine { | ||
from { | ||
box-shadow: inset 0 0 0 100px rgba(255, 200, 0, 0.2); | ||
} | ||
to { | ||
box-shadow: inset 0 0 0 100px rgba(255, 200, 0, 0); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question
: I noticed that this is not associated to a query parameter, as you've requested in previous PRs. Any color about why we're not using an associated query parameter here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question! In this case, this is a conditional component — it only exists when a deployment is active (a much smaller % of the time than when it's in steady state).
If I wanted to add a queryParam that controlled this from the job index route, there would be a majority of time where that queryParam did nothing.
There's an argument to be made for including it anyway, but it seems pretty outweighed by the argument that each deployment is separate and search terms aren't necessarily something you'd want to maintain between all of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha!