tls enforcement flaky tests #16543
Merged
tls enforcement flaky tests #16543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoenig
commented
Mar 17, 2023
Comment on lines
+1397
to
+1398
| TestJoin(t, h.mtlsServer1, h.mtlsServer2, h.nonVerifyServer) | ||
| testutil.WaitForLeaders(t, h.mtlsServer1.RPC, h.mtlsServer2.RPC, h.nonVerifyServer.RPC) |
There was a problem hiding this comment.
instead of starting 1 & 2 with bootstrap = 2 then waiting for a leader then adding server 3 ... start all 3 together with bootstrap = 3 then wait for leader
shoenig
added
backport/1.4.x
This was referenced Mar 17, 2023
shoenig
added a commit
that referenced
this pull request
Mar 17, 2023
shoenig
added a commit
that referenced
this pull request
Mar 17, 2023
shoenig
added a commit
that referenced
this pull request
Mar 17, 2023
(manual cherry pick of 1cfa95e) * tests: add WaitForLeaders helpers using must/wait timings * tests: start servers for mtls tests together Fixes #16253 (hopefully) Co-authored-by: Seth Hoenig <[email protected]>
shoenig
added a commit
that referenced
this pull request
Mar 17, 2023
(manual cherry pick of 1cfa95e) * tests: add WaitForLeaders helpers using must/wait timings * tests: start servers for mtls tests together Fixes #16253 (hopefully) Co-authored-by: Seth Hoenig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16253 ... 🤞