Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of job parsing: fix panic when variable validation is missing condition into release/1.2.x #16019

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #16018 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

The below text is copied from the body of the original PR.


Fixes #12513


Test using the example jobspec from #12513:

$ nomad job run -var 'image_id=foo-' example.nomad
Error getting job struct: Error parsing job file from example.nomad:
example.nomad:5,14-14: Missing required argument; The argument "condition" is required, but no definition was found.
example.nomad:5,3-13: Invalid variable validation specification; validation requires a condition.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-cli-missing-condition-panic/conversely-humane-maggot branch from 90e58f5 to b30d434 Compare February 1, 2023 21:41
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 49fb7e7 into release/1.2.x Feb 1, 2023
@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-cli-missing-condition-panic/conversely-humane-maggot branch from ba23f5d to 46cf23c Compare February 1, 2023 21:41
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/b-cli-missing-condition-panic/conversely-humane-maggot branch February 1, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants