Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acl: fix a bug in token creation when parsing expiration TTLs. #15999

Merged
merged 4 commits into from
Feb 1, 2023

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Feb 1, 2023

The ACL token decoding was not correctly handling time duration
syntax such as "1h" which forced people to use the nanosecond
representation via the HTTP API.

The change adds an unmarshal function which allows this syntax to
be used, along with other styles correctly.

It also includes a docs clarification on the validation params used for
TTL values.

closes #15960

@jrasell jrasell added this to the 1.5.0 milestone Feb 1, 2023
@jrasell jrasell self-assigned this Feb 1, 2023
Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Verified

This commit was signed with the committer’s verified signature.
haydenshively Hayden Shively
The ACL token decoding was not correctly handling time duration
syntax such as "1h" which forced people to use the nanosecond
representation via the HTTP API.

The change adds an unmarshal function which allows this syntax to
be used, along with other styles correctly.

Verified

This commit was signed with the committer’s verified signature.
haydenshively Hayden Shively

Verified

This commit was signed with the committer’s verified signature.
haydenshively Hayden Shively
api/acl.go Outdated Show resolved Hide resolved

Verified

This commit was signed with the committer’s verified signature.
haydenshively Hayden Shively
Co-authored-by: Seth Hoenig <shoenig@duck.com>
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.4.x backport to 1.4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACL Token ExpirationTTL is broken or not documented properly
4 participants