Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix broken link on job-specification/checks page #15968

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

angrycub
Copy link
Contributor

Fixed a broken markdown link. While looking, spotted a typo and an opportunity to tidy up some of the codeblocks

Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹


- `expose` `(bool: false)` - Specifies whether an [Expose Path](/nomad/docs/job-specification/expose#path-parameters)
should be automatically generated for this check. Only compatible with
Connect-enabled task-group services using the default Connect proxy. If set, check
[`type`][type] must be `http` or `grpc`, and check `name` must be set.
[`type`](#type) must be `http` or `grpc`, and check `name` must be set.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one here is the broken link yeah?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Since it is on the same page, we can just link to the ID rather than having to make an additional reference link at the bottom.

```

```
<CodeBlockConfig hideClipboard>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this just get rid of the "Copy" button in the upper-right corner of the code block?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Doesn't seem to make sense to copy example command output

@angrycub angrycub merged commit ca597f7 into main Jan 30, 2023
@angrycub angrycub deleted the d-checks-page-fixes branch January 30, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/docs Documentation issues and enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants