Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of template: restore driver handle on update into release/1.4.x #15923

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #15915 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

The below text is copied from the body of the original PR.


When the template hook Update() method is called it may recreate the template manager if the Nomad or Vault token has been updated.

This caused the new template manager did not have a driver handler because this was only being set on the Poststart hook, which is not called for inplace updates.

Closes #15851

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-template-restore-driver-handle/strangely-wanted-titmouse branch from de1625f to f0f4c87 Compare January 27, 2023 15:59
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit b9ef7ed into release/1.4.x Jan 27, 2023
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/b-template-restore-driver-handle/strangely-wanted-titmouse branch January 27, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants