ui: scope variables form footer style #15907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scope the `footer` tag SCSS rule for the New Variable form to prevent it from affecting other `<footer>` elements, such as the gutter menu Nomad version section.
Ember Asset Size actionAs of 6db25dc Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
philrenaud
approved these changes
Jan 26, 2023
Ember Test Audit comparison
|
ChaiWithJai
reviewed
Jan 26, 2023
Comment on lines
+120
to
+130
| footer { | ||
| display: grid; | ||
| grid-auto-columns: max-content; | ||
| grid-auto-flow: column; | ||
| gap: 1rem; | ||
|
|
||
| .button.is-info.is-inverted.add-more[disabled] { | ||
| border-color: #dbdbdb; | ||
| box-shadow: 0 2px 0 0 rgb(122 122 122 / 20%); | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope the
footertag SCSS rule for the New Variable form to prevent it from affecting other<footer>elements, such as the gutter menu Nomad version section.Currently
mainlooks like this:With this change it centralizes properly again:
No changelog or backport necessary since this is only in
main.