cli: separate auth method config output for easier reading. #15892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkazmierczak
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
I think this is good, it does make the output more readable. Are we sure it doesn't break any formatting conventions? (I don't think our other commands output this way?)
Then again does it matter? If users want a particular way of output formatting, they can use json or template flags.
|
After some random clicking in the docs, I think the only tweak I'd suggest is removing the use of colons on the headers, e.g. https://developer.hashicorp.com/nomad/docs/commands/status#examples And perhaps something more descriptive than "Config" |
shoenig
approved these changes
Jan 26, 2023
jrasell
force-pushed
the
jrasell/f-sso-auth-method-output-separate-config-cli
branch
from
44c65bc to
3b9bce5
Compare
jrasell
deleted the
jrasell/f-sso-auth-method-output-separate-config-cli
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"easier reading" is subjective, so interested in overall feedback on how this looks and what could be improved.