Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acl: modify update endpoints behavior #15580

Merged
merged 6 commits into from
Dec 20, 2022
Merged

acl: modify update endpoints behavior #15580

merged 6 commits into from
Dec 20, 2022

Conversation

pkazmierczak
Copy link
Contributor

@pkazmierczak pkazmierczak commented Dec 19, 2022 •
edited
Loading

API and RPC endpoints for ACLAuthMethods and ACLBindingRules should allow users to send incomplete objects in order to, e.g., update single fields. This PR provides "merging" functionality for these endpoints.

Relates to #13120

@pkazmierczak pkazmierczak added this to the 1.5.0 milestone Dec 19, 2022
@pkazmierczak pkazmierczak self-assigned this Dec 19, 2022
@vercel
Copy link

vercel bot commented Dec 19, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nomad 🔄 Building (Inspect) Dec 19, 2022 at 7:12PM (UTC)
nomad-storybook-and-ui 🔄 Building (Inspect) Dec 19, 2022 at 7:12PM (UTC)

shoenig
shoenig approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; any chance we can add a test case that stresses the changes to UpsertAuthMethods ?

helper/funcs.go Outdated Show resolved Hide resolved
nomad/acl_endpoint.go Show resolved Hide resolved
nomad/acl_endpoint.go Outdated Show resolved Hide resolved
@shoenig
Copy link
Member

shoenig commented Dec 19, 2022 •
edited
Loading

Oooh actually looks like those test failures might be related

Well maybe related, but they're also broken on main https://github.com/hashicorp/nomad/actions/runs/3733911824/jobs/6335331833

@pkazmierczak
Copy link
Contributor Author

pkazmierczak commented Dec 20, 2022 •
edited
Loading

Oooh actually looks like those test failures might be related

Well maybe related, but they're also broken on main https://github.com/hashicorp/nomad/actions/runs/3733911824/jobs/6335331833

oof that's bad. I'll fix in a separate PR.

@pkazmierczak pkazmierczak mentioned this pull request Dec 20, 2022
Merged
@pkazmierczak pkazmierczak merged commit eacecb8 into main Dec 20, 2022
@pkazmierczak pkazmierczak deleted the f-sso-binding-rules-update-behavior-change branch December 20, 2022 10:22
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoenig shoenig shoenig approved these changes

@jrasell jrasell Awaiting requested review from jrasell

Assignees

@pkazmierczak pkazmierczak

Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pkazmierczak @shoenig