Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acl: make sure there is only one default Auth Method per type #15504

Merged
merged 5 commits into from
Dec 9, 2022
Merged

acl: make sure there is only one default Auth Method per type #15504

merged 5 commits into from
Dec 9, 2022

Conversation

pkazmierczak
Copy link
Contributor

@pkazmierczak pkazmierczak commented Dec 8, 2022 •
edited
Loading

This PR adds a check that makes sure we don't insert a duplicate default ACL auth method for a given type.
Relates to #13120

@pkazmierczak pkazmierczak marked this pull request as draft December 8, 2022 17:57
@pkazmierczak pkazmierczak requested a review from jrasell December 9, 2022 11:19
@pkazmierczak pkazmierczak marked this pull request as ready for review December 9, 2022 11:19
jrasell
jrasell reviewed Dec 9, 2022
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and a lovely approach. QQ. do we also want the check we have in the RPC handler within the upsert state method to account for Raft latency?

@pkazmierczak
Copy link
Contributor Author

Looks great and a lovely approach. QQ. do we also want the check we have in the RPC handler within the upsert state method to account for Raft latency?

Good call, I updated in 126a117

jrasell
jrasell approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkazmierczak pkazmierczak merged commit f4e89e2 into main Dec 9, 2022
@pkazmierczak pkazmierczak deleted the f-sso-auth-methods-only-one-default branch December 9, 2022 13:46
@github-actions
Copy link

github-actions bot commented Apr 9, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrasell jrasell jrasell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkazmierczak @jrasell