Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mount propagation to protobuf definition of mounts #15096

Conversation

stswidwinski
Copy link
Contributor

A simple fix for #15014 and the related hashicorp/nomad-driver-podman#192.

Tests pass for the drivers package.

@hashicorp-cla
Copy link

hashicorp-cla commented Nov 1, 2022

CLA assistant check
All committers have signed the CLA.

@stswidwinski
Copy link
Contributor Author

cc: @tgross @ejweber

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @stswidwinski 🙂

Would you mind add tests for this change? I think adding PropagationMode to TestTaskConfigRoundTrip may be a good one, but feel free to add other tests if you see fit.

We also require contributors to sing our CLA before merging work, so you could you this as well?

@stswidwinski
Copy link
Contributor Author

stswidwinski commented Nov 4, 2022 via email

@stswidwinski
Copy link
Contributor Author

The CLA has been signed. Thanks for your patience @lgfa29

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed a commit to add a changelog entry for this. Thank you for the contribution and for taking care of the CLA 🙂

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants