Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of keyring: fix missing GC config, don't rotate on manual GC into release/1.4.x #15017

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #15009 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

The below text is copied from the body of the original PR.


For #14981

The configuration knobs for root keyring garbage collection are present in the consumer and present in the user-facing config, but we missed the spot where we copy from one to the other. Fix this so that users can set their own thresholds.

The root key is automatically rotated every ~30d, but the function that does both rotation and key GC was wired up such that nomad system gc caused an unexpected key rotation. Split this into two functions so that nomad system gc cleans up old keys without forcing a rotation, which will be done periodically or by the nomad operator root keyring rotate command.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-keyring-gc/gently-unique-magpie branch from 36f24cf to db37568 Compare October 24, 2022 12:44
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit cb48493 into release/1.4.x Oct 24, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/b-keyring-gc/gently-unique-magpie branch October 24, 2022 12:44
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants