Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: remove extra space in menu footer #14457

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Sep 2, 2022

Before:
image

After:
image

@lgfa29 lgfa29 added theme/ui backport/1.3.x backport to 1.3.x release line labels Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Ember Asset Size action

As of a385813

Files that got Smaller 🎉:

File raw gzip
nomad-ui.js -13 B 0 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Ember Test Audit comparison

main 44361f7 change
passes 1411 1411 0
failures 0 0 0
flaky 0 0 0
duration 10m 33s 042ms 12m 12s 245ms +1m 39s 203ms

Copy link
Contributor

@ChaiWithJai ChaiWithJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great catch. @philrenaud this "bug" has happened a few times wtrg to handlebars and whitespace. Can we look into our linting/prettier set-up?

@philrenaud
Copy link
Contributor

Updating prettier for this would be ideal. We can also start expanding our visual diff tests to try and catch these kinds of inconsistencies in the future. Thanks @lgfa29 for catching this!

@lgfa29
Copy link
Contributor Author

lgfa29 commented Sep 6, 2022

I think the Prettier config may be OK now since it didn't try to revert this change. But yeah, it may be good to double check 👍

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.3.x backport to 1.3.x release line theme/ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants