-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: remove extra space in menu footer #14457
Conversation
Ember Asset Size actionAs of a385813 Files that got Smaller 🎉:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great catch. @philrenaud this "bug" has happened a few times wtrg to handlebars and whitespace. Can we look into our linting/prettier set-up?
Updating prettier for this would be ideal. We can also start expanding our visual diff tests to try and catch these kinds of inconsistencies in the future. Thanks @lgfa29 for catching this! |
I think the Prettier config may be OK now since it didn't try to revert this change. But yeah, it may be good to double check 👍 |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Before:
After: