Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of warn destructive update only when count > 1 into release/1.3.x #14456

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #13103 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

The below text is copied from the body of the original PR.


The warning doesn't make sense when count is 0 or 1 (destructive anyway). It's distractive and may cause users to ignore useful warnings.

@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 0b4910c into release/1.3.x Sep 2, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/warning/definitely-destined-lioness branch from 075c873 to 1326d60 Compare September 2, 2022 19:53
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/warning/definitely-destined-lioness branch September 2, 2022 19:53
@github-actions
Copy link

github-actions bot commented Jan 1, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants