Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add expired token garbage collection periodic jobs. #13805

Merged

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Jul 18, 2022

Two new periodic core jobs have been added which handle removing
expired local and global tokens from state. The local core job is
run on every leader; the global core job is only run on the leader
within the authoritative region.

related: #13120
targets: feature branch

@jrasell jrasell added this to the 1.4.0 milestone Jul 18, 2022
@jrasell jrasell requested review from schmichael and shoenig July 18, 2022 08:42
@jrasell jrasell self-assigned this Jul 18, 2022
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!; just the usual ignore-able suggestions

nomad/core_sched.go Outdated Show resolved Hide resolved
nomad/core_sched.go Outdated Show resolved Hide resolved
nomad/core_sched.go Outdated Show resolved Hide resolved
nomad/core_sched.go Outdated Show resolved Hide resolved
nomad/leader.go Outdated Show resolved Hide resolved
nomad/leader_test.go Outdated Show resolved Hide resolved
Two new periodic core jobs have been added which handle removing
expired local and global tokens from state. The local core job is
run on every leader; the global core job is only run on the leader
within the authoritative region.
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jrasell jrasell merged commit 14bcc74 into f-gh-13120-acl-token-expiration Jul 19, 2022
@jrasell jrasell deleted the f-gh-13120-expired-token-gc branch July 19, 2022 13:37
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants