Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: external links open in new tabs #12134

Merged
merged 1 commit into from
Feb 25, 2022
Merged

ui: external links open in new tabs #12134

merged 1 commit into from
Feb 25, 2022

Conversation

ChaiWithJai
Copy link
Contributor

No description provided.

@ChaiWithJai ChaiWithJai linked an issue Feb 25, 2022 that may be closed by this pull request
make the click of ui.consul.ui_url open in a new browser TAB #11952
Closed
@github-actions
Copy link

Ember Asset Size action

As of 1d90cbf

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +224 B +7 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

Ember Test Audit comparison

main 1d90cbf change
passes 1270 1270 0
failures 0 0 0
flaky 0 0 0
duration 9m 47s 842ms 9m 38s 528ms -09s 314ms

LevelbossMike
LevelbossMike approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@LevelbossMike LevelbossMike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@ChaiWithJai ChaiWithJai merged commit b76e04d into main Feb 25, 2022
@ChaiWithJai ChaiWithJai deleted the b-ui/target-link branch February 25, 2022 15:29
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LevelbossMike LevelbossMike LevelbossMike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make the click of ui.consul.ui_url open in a new browser TAB
2 participants
@ChaiWithJai @LevelbossMike