namespace refactoring #12082
Merged
namespace refactoring #12082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to adapt the test due to recent namespace changes.
This will give us 'correct' URLs for free when we only pass a `job`-model to a `LinkTo` that links to the `jobs.job.*`-routes.
The new ID handling gives us this behavior for free and we don't need to drill the namespace down through all the route-layers anymore.
* less clever™ metaprogramming when checking for expectedURL * clicking slices job-client-status-summary needs to change its behavior and not pass the namespace query-param anymore.
Default namespaced jobs don't append the `@default`-id anymore due to recent `jobs.job#serialize` changes.
Recent changes changed the behavior of not adding the `@default` -namespace - we need to adapt the tests accordingly
There is no need to check the namespace query-param anymore with `urlWithNamespace` but some tests still are using this. We refactor the tests to be less clever and check the URL in a more manual approach by explicitly defining how the URL should look like if a job belongs to a namespace.
We need to access job-details differently when they have a namespace due to recent namespace changes - we need to make the tests reflect that.
We need to change the way we access `JobDetail`-pages based on recent namespace changes.
* change the breadcrumbs generation to use `idWithNamespace` * adapt tests to reflect new URLs for jobs with namespaces
URLs have changed - tests need to reflect that.
Ember Asset Size actionAs of 02218c6 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
LevelbossMike
approved these changes
Feb 17, 2022
Ember Test Audit comparison
|
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on main:
|
This was referenced Feb 22, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors namespaces in the Nomad UI. Namespaces in the Nomad UI were designed as query parameters and they will now be serialized in the URL with job ids and csi volumes.
RFC: https://docs.google.com/document/d/1ssx1q0k1c3wYhSBS0DIY08njk3jfUdy2cODhgkC7c24/edit