Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: BIN value must use single-path GOPATH value #12080

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Feb 17, 2022

I broke the build due to #12077 not using our workaround for GOPATH

2nd time I've been burned by https://discuss.circleci.com/t/gopath-is-set-to-multiple-directories/7174

Circle: 2 Seth: 0

BIN is /home/circleci/.go_workspace:/usr/local/go_workspace/bin
=== Failed
=== FAIL: command TestIntegration_Command_RoundTripJob (0.13s)
...
    integration_test.go:57: 
        	Error Trace:	integration_test.go:57
        	Error:      	Expected nil, but got: &exec.Error{Name:"nomad", Err:(*errors.errorString)(0xc000129190)}
        	Test:       	TestIntegration_Command_RoundTripJob
    integration_test.go:66: error running example.nomad: exec: "nomad": executable file not found in $PATH

When GOBIN is not set, BIN must be set to the single-path workaround
value of GOPATH, because Circle.
@vercel vercel bot temporarily deployed to Preview – nomad February 17, 2022 15:26 Inactive
@shoenig shoenig changed the title build: circle tests need to know about GOBIN now build: BIN value must use single-path GOPATH value Feb 17, 2022
@shoenig shoenig marked this pull request as ready for review February 17, 2022 16:25
@shoenig shoenig requested a review from lgfa29 February 17, 2022 16:25
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I saw that error in a branch and I thought I had broken it 😅

@shoenig shoenig merged commit 1c1ffe4 into main Feb 17, 2022
@shoenig shoenig deleted the b-fix-gobin-circle branch February 17, 2022 19:48
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants