Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix up very long tag word breaking the allocation service table width #11995

Merged
merged 3 commits into from
Feb 5, 2022
Merged

style: fix up very long tag word breaking the allocation service table width #11995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6746e9e
style: fix up very long word breaking the table width
ttys3 Feb 3, 2022
3c560cb
ui: rename break-word CSS class
lgfa29 Feb 5, 2022
c8f0cc4
changelog: add entry for #11955
lgfa29 Feb 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/11995.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
ui: break long service tags into multiple lines
```
6 changes: 5 additions & 1 deletion ui/app/styles/core/table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use "sass:math";
@use 'sass:math';

.table {
color: $text;
Expand Down Expand Up @@ -103,6 +103,10 @@
}
}

&.is-long-text {
word-break: break-word;
}

// Only use px modifiers when text needs to be truncated.
// In this and only this scenario are percentages not effective.
&.is-200px {
Expand Down
2 changes: 1 addition & 1 deletion ui/app/templates/allocations/allocation/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@
<tr data-test-service>
<td data-test-service-name>{{row.model.name}}</td>
<td data-test-service-port>{{row.model.portLabel}}</td>
<td data-test-service-tags>{{join ", " row.model.tags}}</td>
<td data-test-service-tags class="is-long-text">{{join ", " row.model.tags}}</td>
<td data-test-service-onupdate>{{row.model.onUpdate}}</td>
<td data-test-service-connect>{{if row.model.connect "Yes" "No"}}</td>
<td data-test-service-upstreams>
Expand Down