Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow lower / mixed-case port labels #118

Closed
wants to merge 2 commits into from
Closed

Allow lower / mixed-case port labels #118

wants to merge 2 commits into from

Conversation

cbednarski
Copy link
Contributor

  • Relaxes the regexp
  • Adds ToUpper back to the environment variable code
  • Needs some up-front checking (job spec validation, probably) to prevent collisions

Closes #102

This was referenced Sep 25, 2015
Closed
Merged
@cbednarski cbednarski deleted the b-mixed-case-ports branch September 26, 2015 05:30
@tantra35 tantra35 mentioned this pull request Jun 9, 2016
Closed
@tantra35 tantra35 mentioned this pull request Jun 30, 2016
Closed
@tantra35 tantra35 mentioned this pull request Jul 9, 2016
Closed
schmichael pushed a commit that referenced this pull request Jan 30, 2020
@preetapan
Merge pull request #118 from hashicorp/ossmerge_20190905
cc7c547 
Ossmerge 20190905
benbuzbee pushed a commit to benbuzbee/nomad that referenced this pull request Jul 21, 2022
@slackpad
Merge pull request hashicorp#118 from hashicorp/f-replication-break
d1c5900 
Adds a check of the `stopCh` to break out of the `replicateTo()` loop if needed.
@github-actions
Copy link

github-actions bot commented May 9, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cbednarski