Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix CI #11785

Merged
merged 2 commits into from
Jan 6, 2022
Merged

ui: fix CI #11785

merged 2 commits into from
Jan 6, 2022

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jan 6, 2022

#11590 introduced a few changes due to auto-formatting that caused CI to break. #11754 will address these issues, but until it's merged, this PR aims to revert those changes to make sure main is properly tested in CI. Reverting these changes also help us validate that #11754 will format templates properly.

@lgfa29 lgfa29 requested a review from ChaiWithJai January 6, 2022 19:54
Copy link
Contributor

@ChaiWithJai ChaiWithJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Ember Asset Size action

As of 981a259

Files that got Smaller 🎉:

File raw gzip
nomad-ui.js -2.85 kB -277 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Ember Test Audit comparison

main 981a259 change
passes 1235 1233 -2
failures 1 1 0
flaky 1 4 +3
duration 000ms 000ms -000ms

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on main:

  • Acceptance | task group detail: /jobs/:id/:task-group should list high-level metrics for the allocation

Ember Test Audit detected these flaky tests on 981a259:

  • Acceptance | task group detail: /jobs/:id/:task-group second breadcrumb should link to the job for the task group
  • Integration | Component | TopoViz: clicking on an allocation in a deeply nested TopoViz::Node will associate sibling allocations with curves
  • Integration | Component | TopoViz: when the count of sibling allocations is high enough relative to the node count, curves are not rendered
  • Integration | Utility | exec-socket-xterm-adapter: resizing the window passes a resize message through the socket

@lgfa29 lgfa29 merged commit f34e76a into main Jan 6, 2022
@lgfa29 lgfa29 deleted the ui-fix-ci branch January 6, 2022 21:01
@github-actions
Copy link

github-actions bot commented Nov 5, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants