Override TLS flags individually for meta commands #11592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekStrickland
force-pushed
the
b-gh-11460-tls-skip-verify
branch
from
1ac9424 to
fe5c7c3
Compare
DerekStrickland
force-pushed
the
b-gh-11460-tls-skip-verify
branch
from
fe5c7c3 to
8e6c989
Compare
Co-authored-by: Tim Gross <[email protected]>
lgfa29
pushed a commit
that referenced
this pull request
Jan 17, 2022
* Override TLS flags individually for meta commands * Update command/meta.go Co-authored-by: Tim Gross <[email protected]> Co-authored-by: Tim Gross <[email protected]>
lgfa29
pushed a commit
that referenced
this pull request
Jan 17, 2022
* Override TLS flags individually for meta commands * Update command/meta.go Co-authored-by: Tim Gross <[email protected]> Co-authored-by: Tim Gross <[email protected]>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This block used to set the entire config.TLSConfig with the
values passed by the user. This worked fine if the user set all the options,
or at least enough, but had the unintended side effect of overwriting values
that had been configured in environment variables. If the user passed only
one setting, say
tls-skip-verify, all the other settings, like CACert wouldget overwritten with blank strings.