Upgrade ember data to 3.24 and model fragments to 5.0.0-beta.2 #11447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An empty string is not a valid JSON response which is expected by this endpoint.
|
|
`allocation.reload()` has differnt semantics for reloading, as it will reload the record in the background and immediately resolve [1]. By using the stores' findRecord and specifying `backgroundReload: false`, we make sure we await the response from the server and hereby have the complete record once we continue in the code. Using `allocation.reoad()` causes and infinite loop when we upgrade ember-data to 3.16 (and model fragments to 5.0.0-beta.2). [1] This is, unless `shouldBackgroundReload` on the adapter returns false, but it's true by default.
ChaiWithJai
approved these changes
Nov 4, 2021
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChaiWithJai here's the result of my investigation to the failing upgrade. Feel free to use the changes within #11419 .