Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: only dipslay "Dispatch Job" button on parameterized jobs #11019

Merged
merged 2 commits into from
Aug 9, 2021

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Aug 9, 2021

The Dispatch Job button is only supported on parameterized jobs. Currently it is also being displayed in periodic jobs as well. Clicking the button in a non-parameterized job can cause the UI to crash.

@vercel vercel bot temporarily deployed to Preview – nomad August 9, 2021 21:02 Inactive
@lgfa29 lgfa29 requested a review from ChaiWithJai August 9, 2021 21:03
@lgfa29 lgfa29 added backport/1.1 stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/ui type/bug and removed stage/accepted Confirmed, and intend to work on. No timeline committment though. labels Aug 9, 2021
@github-actions
Copy link

github-actions bot commented Aug 9, 2021

Ember Asset Size action

As of c096a87

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +110 B +17 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Aug 9, 2021

Ember Test Audit comparison

main c096a87 change
passes 1107 1107 0
failures 0 0 0
flaky 0 0 0
duration 7m 31s 888ms 7m 28s 825ms -03s 063ms

@lgfa29 lgfa29 merged commit 8e33fc5 into main Aug 9, 2021
@lgfa29 lgfa29 deleted the b-hide-dispatch-btn branch August 9, 2021 21:49
@schmichael schmichael added this to the 1.1.4 milestone Sep 20, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants