Add metrics for blocked eval resources #10454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
force-pushed
the
f-blocked-eval-resource-metrics
branch
from
e36120c to
932e50d
Compare
lgfa29
force-pushed
the
f-blocked-eval-resource-metrics
branch
from
932e50d to
8f5b20c
Compare
tgross
requested changes
Apr 28, 2021
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an eval is blocked, it's often because of insufficient resources available. Nomad currently tracks now many evals are blocked, but it has not indication of how much resource is required to unblock them, or how where they are assigned to run.
This PR adds a new set of metrics that emit how much resource have been requested by blocked evals. The metrics are split into jobs, datacenters and node classes.
If a job spans multiple datacenters or node classes, they will all be updated, since adding more resources to any of them would be enough to unblock the eval.
This metric is emitted by the leader, since it is the only node in the cluster that has the proper scheduling information.
Missing work: