Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameterized <-> non-parameterized job error #10357

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Conversation

angrycub
Copy link
Contributor

The error messages are reversed from tests performed above them. The test uses the validateJobUpdate() function, but ignores the text of the error message itself.

The error messages are reversed from tests performed above them.  The test uses the `validateJobUpdate()` function, but ignores the text of the error message itself.
@angrycub angrycub added type/bug theme/api HTTP API and SDK issues labels Apr 12, 2021
@angrycub angrycub requested review from schmichael and tgross April 12, 2021 01:55
@angrycub angrycub self-assigned this Apr 12, 2021
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @angrycub!

@angrycub angrycub merged commit 02a8e6c into main Apr 12, 2021
@angrycub angrycub deleted the b-cv-fix-error-msg branch April 12, 2021 13:27
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/api HTTP API and SDK issues type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants