Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: extend CSI test to cover create and snapshot workflows #10322

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Conversation

tgross
Copy link
Member

@tgross tgross commented Apr 7, 2021

Split the EBS and EFS tests out into their own test cases:

  • EBS exercises the Controller RPCs, including the create/snapshot workflow. Drop the Terraform-created volume in lieu of the one created by the test.
  • EFS exercises only the Node RPCs, and assumes we have an existing volume that gets registered, rather than created.

Note: assumes #10330 and #10331 get merged.

Split the EBS and EFS tests out into their own test cases:
* EBS exercises the Controller RPCs, including the create/snapshot workflow.
* EFS exercises only the Node RPCs, and assumes we have an existing volume
that gets registered, rather than created.
f.Assert().NoError(err, out)
// requireNoErrorElseDump calls a halting assert on the error and dumps the
// plugin logs if it fails.
func requireNoErrorElseDump(f *framework.F, err error, msg string, pluginJobIDs []string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Contributor

@drewbailey drewbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tgross tgross merged commit f133a89 into main Apr 8, 2021
@tgross tgross deleted the e2e-csi-ebs branch April 8, 2021 16:55
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants