CSI: volume creation #10165
Merged
CSI: volume creation #10165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
csi-create-volume
branch
from
c10f708 to
f29399a
Compare
tgross
force-pushed
the
csi-create-volume
branch
from
f29399a to
eade3e0
Compare
tgross
force-pushed
the
csi-create-volume
branch
from
bbb9699 to
d84a4ce
Compare
This was referenced Mar 22, 2021
tgross
force-pushed
the
csi-create-volume
branch
from
2fe11bd to
d536bfb
Compare
This was referenced Mar 24, 2021
tgross
force-pushed
the
csi-create-volume
branch
from
d536bfb to
7a73906
Compare
drewbailey
reviewed
Mar 31, 2021
tgross
force-pushed
the
csi-create-volume
branch
from
3bbaf8b to
e665757
Compare
tgross
force-pushed
the
csi-create-volume
branch
from
e665757 to
3acde0d
Compare
drewbailey
approved these changes
Mar 31, 2021
Note that unset proto fields for volume create should be nil. The CSI spec handles empty fields and nil fields in the protobuf differently, which may result in validation failures for creating volumes with no prior source (and does in testing with the AWS EBS plugin). Refactor the `CreateVolumeRequest` mapping to the protobuf in the plugin client to avoid this bug.
This commit includes a new test client that allows overriding the RPC protocols. Only the RPCs that are passed in are registered, which lets you implement a mock RPC in the server tests. This commit includes an example of this for the ClientCSI RPC server.
This commit implements the RPC handlers on the client that talk to the CSI plugins on that client for the Create/Delete/List RPC.
The CSI specification requires that we validate a list of `Capability` (access mode + accessibility) when we create volume, but the existing volume registration workflow incorrectly validates a single capability. The specific capability required by a volume claim is checked at the time we make the claim, so remove the check for `AttachmentMode`/`AcccessMode`.
In order to support new controller RPCs, we need to fingerprint volume capabilities in more detail and perform controller RPCs only when the specific capability is present. This fixes a bug in Ceph support where the plugin can only suport create/delete but we assume that it also supports attach/detach.
The HTTP test to create CSI volumes depends on having a controller plugin to talk to, but the test was using a node-only plugin, which allows it to silently ignore the missing controller.
Add new commands for creating, deleting, and listing external storage volumes. Includes HCL decoding update for volume spec so that we can humanize capacity bytes input values.
tgross
force-pushed
the
csi-create-volume
branch
from
3acde0d to
282d54b
Compare
This was referenced Apr 1, 2021
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSI volume creation workflow for #8212. The snapshot and resize workflows will be implemented in separate PRs once this is complete.
Consists of the contents of these PRs, previously reviewed and merged:
I've rebased these a bit to squash redundant commits on the same content and fixup doc navigation updates, so that we have a git-bisectable result once this PR is merged. But no content has changed other than the docs navigation file.