Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: upgraded prometheus http client #5850

Merged
merged 4 commits into from
Jun 19, 2019

Conversation

cgbaker
Copy link
Contributor

@cgbaker cgbaker commented Jun 18, 2019

upgrade to [email protected] to address label conflict in Nomad 0.9.x

resolves #5345

CHANGELOG.md Show resolved Hide resolved
@cgbaker cgbaker merged commit e029478 into master Jun 19, 2019
@notnoop notnoop deleted the b-5345-prometheus-metric-label-conflict branch June 22, 2019 06:11
@rgl
Copy link

rgl commented Nov 26, 2020

Can this please be re-visisted/re-checked?

I'm also posting this to #6242:

I'm using nomad 1.0.0-beta3 and the metric label is still job instead of job_name. For example:

nomad_client_allocs_cpu_allocated{alloc_id="b15d7cc8-22d5-3e31-4a6d-096f8075abce",job="go-info",namespace="default",task="go-info",task_group="go-info"}

This means that when read from prometheus it will end up being named exported_job:

nomad_client_allocs_cpu_allocated{alloc_id="b15d7cc8-22d5-3e31-4a6d-096f8075abce",exported_job="go-info",instance="client1:4646",job="nomad",namespace="default",task="go-info",task_group="go-info"}

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus metric data job label name conflict
3 participants