Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename job metrics label to job_name #6242

Closed
wants to merge 1 commit into from
Closed

rename job metrics label to job_name #6242

wants to merge 1 commit into from

Conversation

stremovsky
Copy link

Another fix for: #5345

@hashicorp-cla
Copy link

hashicorp-cla commented Sep 1, 2019

CLA assistant check
All committers have signed the CLA.

@notnoop
Copy link
Contributor

notnoop commented Jul 24, 2020

Thank you for your contribution. It seems that #5345 was closed by #5850 so this is no longer needed. Closing this - please reopen if you are still seeing issues. Thank you so much!

@notnoop notnoop closed this Jul 24, 2020
@rgl
Copy link

rgl commented Nov 26, 2020

@notnoop I'm using nomad 1.0.0-beta3 and the metric label is still job instead of job_name. For example:

nomad_client_allocs_cpu_allocated{alloc_id="b15d7cc8-22d5-3e31-4a6d-096f8075abce",job="go-info",namespace="default",task="go-info",task_group="go-info"}

This means that when read from prometheus it will end up being named exported_job:

nomad_client_allocs_cpu_allocated{alloc_id="b15d7cc8-22d5-3e31-4a6d-096f8075abce",exported_job="go-info",instance="client1:4646",job="nomad",namespace="default",task="go-info",task_group="go-info"}

Can this be re-opened?

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants