Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the prefix of the service id #579

Merged
merged 2 commits into from
Dec 14, 2015
Merged

Changing the prefix of the service id #579

merged 2 commits into from
Dec 14, 2015

Conversation

diptanu
Copy link
Contributor

@diptanu diptanu commented Dec 14, 2015

cc/ @c4milo

@c4milo
Copy link
Contributor

c4milo commented Dec 14, 2015

LGTM

dadgar
dadgar reviewed Dec 14, 2015
View reviewed changes
nomad/structs/structs.go
@@ -1146,7 +1146,7 @@ func (sc *ServiceCheck) Hash(serviceId string) string {
}

const (
NomadConsulPrefix = "nomad"
NomadConsulPrefix = "1729nomad"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it have to be a number? Why not: [nomad-registered-service]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or n0m4d ;D Honestly, that's a minor detail to me, as long as it does not easily clash with users's service IDs I'm ok with whatever prefix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't care much either. Fixing a test, might as well make it what Alex suggested so that it's more human readable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

diptanu added a commit that referenced this pull request Dec 14, 2015
@diptanu
Merge pull request #579 from hashicorp/f-consul-service-prefix
8540ec4 
Changing the prefix of the service id
@diptanu diptanu merged commit 8540ec4 into master Dec 14, 2015
@diptanu diptanu deleted the f-consul-service-prefix branch December 14, 2015 20:54
@github-actions
Copy link

github-actions bot commented May 1, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diptanu @c4milo @dadgar