Add support for go-getter modes #2781
Conversation
|
@schmichael I would note for the minio support, you must explicitly set the protocol to S3. I can send a separate pr to update the docs if you want or you can just include it here. I should also update the readme for go-getter |
|
@lfarnell Good call! I'm updating Nomad's docs right now. Mind doing the PR against go-getter's README? Thanks! |
|
@schmichael So I must have updated the README for go-getter and not remembered. All good to go 😄 |
|
Thanks for this PR @schmichael - will make stuff a lot simpler for us going forward! 0.6 will be an epic release by the look of it |
CHANGELOG.md
Outdated
| @@ -44,6 +44,8 @@ BUG FIXES: | |||
| allocation destroy fixing a corner case in which an allocation may be blocked | |||
| till destroy [GH-2563] | |||
| * client/artifact: Honor netrc [GH-2524] | |||
| * client/artifact: Allow specifying a go-gettter mode [GH-2781] | |||
schmichael
force-pushed
the
f-2678-getter-mode
branch
from
6ac25fc to
9d2682e
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #2678
Also updates go-getter to hashicorp/go-getter#69 so we now support S3 alternatives.