artifact {} with custom destination does not work as advertised

[jippi]

Nomad version

0.5.1-rc1

Operating system and Environment details

Linux Debian 7.9

Issue

Based on the docs

artifact {
  source      = "https://example.com/file.txt"
  destination = "/tmp/example.txt"
}

should create /tmp/example.txt, though adjusting it to my own paths like below, this is not the case

artifact {
	source      = "https://xxxx/template/{{PROJECT_NAME}}/{{APP_ENV}}/{{APP_VERSION}}/consul-template/php-fpm.ctmpl"
	destination = "/local/php-fpm.conf"
}

It actually created /server/local/php-fpm.conf/php-fpm.ctmpl instead. Thus using the destination as a directory (ignoring the file part) and putting the file inside the destination directory as-named on the source url

[dadgar]

Hey destination is relative to the allocation directory. It is not absolute. Please see the documentation: https://www.nomadproject.io/docs/job-specification/artifact.html#destination

Agree that it should do a rename rather than a join.

[jippi]

@dadgar know it's "relative" :) the only problem is the destination is really just the directory, so end result is ${destination}/${basename source} which is very surprising :P

[dadgar]

@jippi This isn't really possible with the API of go-getter. It assumes destination is a folder, just dug into the API. The only way to do this is to introduce a new option in the artifact block file = true which would treat it as a file and download it to that file name. Is that desirable? If file = true and you download not a file it would error.

[dadgar]

Talked in Gitter, but following up. Added better documentation in this commit: 30655ef

I want to avoid a special flag and until a very compelling case comes up, the docs should suffice.

[jippi]

@dadgar seems legit to me ! thank you

[shantanugadgil]

@dadgar @jippi

I stumbled upon this same issue today.

In my opinion, not able to specify the file name, enforces an artificial constraint on the user.

I had imagined that I would be able to keep various config files together in my S3 bucket, and based on some option, be able to pick any one from the S3 bucket and save it with a common name in the destination.
This was so that my docker could then assume a fixed named for the config file.

Being able to name the destination file seemed obvious to me. Hope this gets implemented.

• Having an extra "file" parameter doesn't seem elegant though.

Regards,
Shantanu

[jippi]

Pretty sure this is fixed in next release as go-getter now support file mode :)

[shantanugadgil]

FWIW, I am using version Nomad v0.6.0-rc1 (5187fcfcae50e3dee61e5340eb99805a564b55c3+CHANGES)

Could you point me to the place where go-getter mentions how to set target as a file ?
I couldn't find any open/closed issue in the go-getter issues section about this. 😢
https://github.com/hashicorp/go-getter/issues

Regards,
Shantanu

[jippi]

I think #2781 is what you are looking for

[jippi]

See https://github.com/hashicorp/nomad/pull/2781/files#diff-37b5aa5df3b4c75cad9afbd78b0654bcR55

[shantanugadgil]

@jippi Thanks, Got it!
mode = "file"

👍

Regards,
Shantanu

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.