-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple nomad cli commands fail if there are multiple prefix matches #23236
Comments
@henrikjohansen can you clarify what you steps you're taking here? That is, suppose we have two quotas |
@tgross ... an example with my v1.8.0 test cluster :
Now, looking at the namespace quota fails with :
|
As I mentioned other commands have similar issues :
|
Ok thanks @henrikjohansen. So the problem is when there is an exact match in addition to the multiple prefix matches. That issue was previously reported with CSI volumes #17132, but it looks like it's pervasive. |
I just stumbled across #13920 so it might as well be mentioned here. |
PR in progress here: #23502 |
Several commands that inspect objects where the names are user-controlled share a bug where the user cannot inspect the object if it has a name that is an exact prefix of the name of another object (in the same namespace, where applicable). For example, the object "test" can't be inspected if there's an object with the name "testing". Copy existing logic we have for jobs, node pools, etc. to the impacted commands: * `plugin status` * `quota inspect` * `quota status` * `scaling policy info` * `service info` * `volume deregister` * `volume detach` * `volume status` If we get multiple objects for the prefix query, we check if any of them are an exact match and use that object instead of returning an error. Where possible because the prefix query signatures are the same, use a generic function that can be shared across multiple commands. Fixes: #13920 Fixes: #17132 Fixes: #23236 Ref: https://hashicorp.atlassian.net/browse/NET-10054 Ref: https://hashicorp.atlassian.net/browse/NET-10055
Nomad version
Nomad v1.7.8 (but 1.6.x had the same issues)
Issue
Multiple commands in the CLI fail when there are multiple prefixes - so far I have seen this with :
nomad quota status
nomad quota inspect
nomad service info
nomad volume deregister
.... but I suspect that there may be others.
Reproduction steps
Create a bunch of similarly named quotas / volumes / services and use the above mentioned commands.
Expected Result
The commands should work without giving a "Prefix matched multiple" error
Actual Result
The commands fail with a "Prefix matched multiple" error
The text was updated successfully, but these errors were encountered: