Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task directories under alloc_mounts are left behind #22433

Closed
shoenig opened this issue May 31, 2024 · 0 comments · Fixed by #23237
Closed

task directories under alloc_mounts are left behind #22433

shoenig opened this issue May 31, 2024 · 0 comments · Fixed by #23237
Labels
theme/client type/bug
Milestone
1.8.1

Comments

@shoenig
Copy link
Member

shoenig commented May 31, 2024

Once a task is garbage collected there should be no trace of it left on the Client. Tasks making use of the unveil isolation mode are leaving empty task directories under the alloc_mounts parent. e.g.

➜ sudo tree -p -d -u
[drwxr-xr-x root    ]  .
├── [drwx--x--x root    ]  alloc_mounts
│   ├── [drwx--x--- 81964   ]  8f825711-9d3f-d44f-62c5-ceb786004d55-nomad-token
│   ├── [drwx--x--- 89340   ]  8f825711-9d3f-d44f-62c5-ceb786004d55-password
└── [drwx------ root    ]  data
    ├── [drwx--x--x root    ]  alloc
    ├── [drwx------ root    ]  client
    └── [drwxr-xr-x root    ]  server
        ├── [drwx------ root    ]  keystore
        ├── [drwxr-xr-x root    ]  raft
        │   └── [drwxr-xr-x root    ]  snapshots
        └── [drwxr-xr-x root    ]  serf

While we do unmount things we are failing to actually delete the directory.
@shoenig shoenig added this to the 1.8.1 milestone May 31, 2024
@shoenig shoenig mentioned this issue Jun 6, 2024
Merged
shoenig added a commit that referenced this issue Jun 6, 2024
@shoenig
client: cleanup empty task directory when using unveil filesystem iso…
9460cbc 
…lation

This PR fixes a bug where Nomad client would leave behind an empty directory
created on behalf of tasks making use of the unveil filesystem isolation
mode (i.e. using exec2 task driver). Once unmounting is complete, we should
remember to also delete the directory.

Fixes #22433
shoenig added a commit that referenced this issue Jun 6, 2024
@shoenig
client: cleanup empty task directory when using unveil filesystem iso…
45da80b 
…lation (#23237)

This PR fixes a bug where Nomad client would leave behind an empty directory
created on behalf of tasks making use of the unveil filesystem isolation
mode (i.e. using exec2 task driver). Once unmounting is complete, we should
remember to also delete the directory.

Fixes #22433
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme/client type/bug
Projects
None yet
Milestone
1.8.1
Development

Successfully merging a pull request may close this issue.

client: cleanup empty task directory when using unveil filesystem isolation hashicorp/nomad
1 participant
@shoenig